Contents tree: add fallback to URL without fragment
ClosedPublic

Authored by alnikiforov on Mar 2 2020, 8:26 AM.

Details

Summary

If URL has fragment, but no such URL with specified fragment
is present in contents tree, try to fallback to URL without any fragment
if such URL is present.

Test Plan

First test case, checking new behaviour:

  1. In contents tree open: "Fundamentals" -> "Finding Your Way Around" -> "Common Menus"
  2. Scroll down to "The Tools Menu" section and click "Check Spelling" link.
  3. In contents tree "Common Tasks" item should be expanded and "Check Spelling" item should be selected.

Second test case, verifying that old behaviour is not broken:

  1. In contents tree open: "Application Manuals" -> "System" -> "Dolphin"
  2. In the table of contents on right side of application scroll down and click "3. Configuring Dolphin"
  3. In contents tree "Dolphin" item should be expanded and "Configuring Dolphin" should be selected.
  4. Click 'back' button, and in the table of contents on right side of application scroll down and click "The Dolphin Preferences Dialog"
  5. In contents tree "Dolphin" and "Configuring Dolphin" items should be expanded and "The Dolphin Preferences Dialog" should be selected.

Diff Detail

Repository
R125 KHelpCenter
Lint
Lint Skipped
Unit
Unit Tests Skipped
alnikiforov created this revision.Mar 2 2020, 8:26 AM
Restricted Application added a project: Documentation. · View Herald TranscriptMar 2 2020, 8:26 AM
Restricted Application added a subscriber: kde-doc-english. · View Herald Transcript
alnikiforov requested review of this revision.Mar 2 2020, 8:26 AM

There are other pending requests that were pending uncommitted. Would you like to push them into the repo first?

There are other pending requests that were pending uncommitted. Would you like to push them into the repo first?

That would be great. But AFAIK I don't have commit permissions.

yurchor accepted this revision.Mar 6 2020, 5:59 PM

Thanks.

This revision is now accepted and ready to land.Mar 6 2020, 5:59 PM
This revision was automatically updated to reflect the committed changes.