Differential D27768

Calendarsupport: add more info to the calendar collection tooltip
ClosedPublic
Actions

Authored by winterz on Mar 1 2020, 5:06 PM.

Details

Reviewers
dvratil
mlaurent
vkrause
Commits
R75:b119d039772a: utils.cpp - add more info to the calendar collection tooltip
Summary

adds some more useful info:

    • if this is the default calendar
  • content type (simplified for user consumption)

@Dan is there a better way to get the content type without having to massage the mimeTypes list? I don't think the user needs to see "application/x-vnd/akonadi.. " stuff

@all I guess this cannot go into the stable branch due to the i18n strings?

Test Plan

tried it out on lots of different collections

Diff Detail

Repository
R75 PIM: Calendar Support
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
winterz created this revision.Mar 1 2020, 5:06 PM
Restricted Application added a project: KDE PIM. · View Herald TranscriptMar 1 2020, 5:06 PM
Restricted Application added a subscriber: kde-pim. · View Herald Transcript
winterz requested review of this revision.Mar 1 2020, 5:06 PM
mlaurent requested changes to this revision.Mar 1 2020, 5:54 PM
mlaurent added inline comments.
src/utils.cpp
694

Are you sure that all the time it's a virtiual calendar ?
(What is a virtual calendar ?)

705

QLatin1String("") ->QString()

This revision now requires changes to proceed.Mar 1 2020, 5:54 PM
mlaurent added a comment.Mar 1 2020, 5:54 PM

yep master only

winterz added inline comments.Mar 1 2020, 9:17 PM
src/utils.cpp
694

a virtual calendar contains incidences from various other calendars that match a tag or category, etc, like the results of a search

705

right

707

is there a better way to join together strings in a comma-separated list for internationalization?
I forget

dvratil added inline comments.Mar 3 2020, 8:16 AM
src/utils.cpp
707

QLocale::createSeparatedList() ?

winterz updated this revision to Diff 76864.Mar 3 2020, 4:10 PM

use QLocale().createSeparatedList() for creating the comma-separated list of content types

This revision was not accepted when it landed; it landed in state Needs Review.Mar 5 2020, 2:46 PM
Closed by commit R75:b119d039772a: utils.cpp - add more info to the calendar collection tooltip (authored by winterz). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/utils.cpp (24 lines)

Diff 77034

View Options

src/utils.cpp

Loading...