Make HTML and external reference warnings more distinguishable
ClosedPublic

Authored by vkrause on Mar 1 2020, 1:27 PM.

Details

Summary

Those have significantly different severity, so show them in different
colors and use different icons.

Diff Detail

Repository
R94 PIM: Message Library
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
vkrause created this revision.Mar 1 2020, 1:27 PM
Restricted Application added a project: KDE PIM. · View Herald TranscriptMar 1 2020, 1:27 PM
Restricted Application added a subscriber: kde-pim. · View Herald Transcript
vkrause requested review of this revision.Mar 1 2020, 1:27 PM
mlaurent accepted this revision.Mar 1 2020, 2:00 PM
mlaurent added a subscriber: mlaurent.

ok cool :)

This revision is now accepted and ready to land.Mar 1 2020, 2:00 PM
ognarb added a subscriber: ognarb.Mar 1 2020, 3:35 PM

The contrast for the link (by clicking here) is very bad, maybe using #00CCFF or a similar color for the link can improve the contrast.

The contrast for the link (by clicking here) is very bad, maybe using #00CCFF or a similar color for the link can improve the contrast.

Link color seems to be KColorScheme scheme(QPalette::Active, KColorScheme::View).foreground(KColorScheme::LinkText).color() - does this need to be fixed in the breeze dark color scheme, or are we using the wrong entry from KColorScheme here?

This revision was automatically updated to reflect the committed changes.