When current directory is in the removable media, upon ejection, return home instead of staying in the removable media directory.
BUG: 158934
FIXED-IN: 20.04.0
Details
Details
- Reviewers
meven elvisangelaccio birkhoff - Group Reviewers
Dolphin
Used a flash drive to test eject functionality with or without terminal open in dolphin, previously only worked when terminal is open.
Diff Detail
Diff Detail
- Repository
- R318 Dolphin
- Branch
- eject-fix
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 23114 Build 23132: arc lint + arc unit
Comment Actions
Apparently this patch will fix bug 158934.
With this patch, what will happen if the device is unmounted instead of ejected?
Comment Actions
Thanks for digging that up!
With this patch, what will happen if the device is unmounted instead of ejected?
Same thing: the view switches to your home dir if you're currently viewing a path in the now-unmounted drive.
Comment Actions
Tested this patch myself on Arch Linux.
It does not work when I eject an optical disc. It works when I unmount ("Release") the disc instead.
Dolphin switches to Home before I enter password to confirm unmounting of internal hard disk partition.
Comment Actions
Hmm, then it looks like we might want to instead implement the logic in PlacesItemModel::slotStorageTearDownDone(), after all the error handling. That way we can be sure the operation has fully completed and all errors are handled before we try to switch to the home dir path.
Comment Actions
Re-submitted with a different approach in https://invent.kde.org/system/dolphin/-/merge_requests/76.