Fixed margin of digital clock

Authored by niccolove on Feb 29 2020, 11:28 AM.



The clock was too close to the panel right edge when displaying hours beginning with 10, 11 and 12. Weirdly enough, the right margin was different based on the clock current time. This patch makes the margin constantly equal to the one that there was before when displaying 10,11,12 plus units.smallSpacing.

Diff Detail

R120 Plasma Workspace
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.
niccolove created this revision.Feb 29 2020, 11:28 AM
Restricted Application added a project: Plasma. · View Herald TranscriptFeb 29 2020, 11:28 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
niccolove requested review of this revision.Feb 29 2020, 11:28 AM
niccolove edited the summary of this revision. (Show Details)Feb 29 2020, 11:30 AM
niccolove added reviewers: VDG, Plasma.
davidedmundson accepted this revision.Feb 29 2020, 5:46 PM
davidedmundson added a subscriber: davidedmundson.

code wise it makes much more sense than the original one

This revision is now accepted and ready to land.Feb 29 2020, 5:46 PM
ngraham accepted this revision.Feb 29 2020, 5:47 PM

Visually +1 too.

Stable branch?

gvgeo added a subscriber: gvgeo.EditedFeb 29 2020, 5:49 PM

By using paintedWidth size is going to change constantly and will move the rest of the widgets.

Edit: Seams to change only when the extra "1" appears.
It will be better that what is it now. +1 from me too.

This revision was automatically updated to reflect the committed changes.

Is this correct, or is there anything special I have to do to land it to stable?

gvgeo added a comment.Feb 29 2020, 6:46 PM

I was too late, it does change constantly now. But it depends on the font. The default font has the same width for all numbers, others don't.

Wish I could at least help with git, but I struggle with it.