Differential D27718

Make Accor extractor work with German reservation mails
ClosedPublic
Actions

Authored by broulik on Feb 28 2020, 9:03 AM.

Details

Reviewers
vkrause
Commits
R1003:0924beb894f9: Make Accor extractor work with German reservation mails
Summary

Found an old reservation in my inbox, adjusted the labels and date format to support it, too.

Test Plan

Managed to extract reservation number and dates correctly.

I also have my name in the reservation, but not sure what the english label would have been.
Also, I have an "online check in" link which we could make turn into an CheckInAction?

Diff Detail

Repository
R1003 KItinerary: Travel Reservation handling library
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Feb 28 2020, 9:03 AM
Restricted Application added a project: KDE PIM. · View Herald TranscriptFeb 28 2020, 9:03 AM
Restricted Application added a subscriber: kde-pim. · View Herald Transcript
broulik requested review of this revision.Feb 28 2020, 9:03 AM
broulik updated this revision to Diff 76602.
  • Join Array with separator
vkrause accepted this revision.Feb 28 2020, 9:13 AM

Thanks, and yes, there's certainly more information to extract there. The English label for the name is "Reservation made in the name of", its location moved down a table between 2017 and 2019 it seems.

This also shows a nicer way for multi-language date/time extraction would simplify extractors quite a bit...

This revision is now accepted and ready to land.Feb 28 2020, 9:13 AM
Closed by commit R1003:0924beb894f9: Make Accor extractor work with German reservation mails (authored by broulik). · Explain WhyFeb 28 2020, 9:16 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/extractors/accor.js (16 lines)

Diff 76603

View Options

src/extractors/accor.js

Loading...