Differential D27715

Port to Qt 5.14 + Android
ClosedPublic
Actions

Authored by apol on Feb 28 2020, 2:52 AM.

Details

Reviewers
vkrause
Group Reviewers
Android
Commits
R325:c99b147592f4: Port to Qt 5.14 + Android
Summary

There's a series of things that should be done differently nowadays on Android.

Test Plan

Tested the application on my Android phone.

Diff Detail

Repository
R325 KAlgebra
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
apol created this revision.Feb 28 2020, 2:52 AM
Restricted Application added a project: KDE Edu. · View Herald TranscriptFeb 28 2020, 2:52 AM
Restricted Application added a subscriber: kde-edu. · View Herald Transcript
apol requested review of this revision.Feb 28 2020, 2:52 AM
vkrause accepted this revision.Feb 28 2020, 8:04 AM
vkrause added a subscriber: vkrause.

Interesting, why is libs.xml checked in here? Usually androiddeployqt provides that I think. This might be a possible way out of the compatibility problem though: if libs.xml just defines all arrays the manifest can contain references to all of them as well, without breaking the build. Those not used in the corresponding Qt version will then just be empty but not cause any issue at runtime either.

In general this looks all correct to me and should work.

This revision is now accepted and ready to land.Feb 28 2020, 8:04 AM
vatra added a subscriber: vatra.Feb 28 2020, 9:27 AM
vatra added inline comments.
mobile/pluginsmodel.cpp
30

What kind of plugins are you loading here? I hope you're not storing .so files in "assets:" because it won't work

apol added a comment.Feb 28 2020, 10:00 AM
In D27715#619276, @vkrause wrote:

Interesting, why is libs.xml checked in here? Usually androiddeployqt provides that I think. This might be a possible way out of the compatibility problem though: if libs.xml just defines all arrays the manifest can contain references to all of them as well, without breaking the build. Those not used in the corresponding Qt version will then just be empty but not cause any issue at runtime either.

In general this looks all correct to me and should work.

It's entirely legacy reasons. I could remove it for sure.

mobile/pluginsmodel.cpp
30

It's qml files.

apol updated this revision to Diff 76786.Mar 2 2020, 4:41 PM

remove unneeded file

Closed by commit R325:c99b147592f4: Port to Qt 5.14 + Android (authored by apol). · Explain WhyMar 4 2020, 12:30 PM
This revision was automatically updated to reflect the committed changes.

Showing Only Differences

This revision modifies 3 more files that are hidden because they were not modified between selected diffs and they have no inline comments.

Revision Contents
Changeset List

PathPackages
Mmobile/pluginsmodel.cpp (2 lines)

Diff 76928

View Options

mobile/pluginsmodel.cpp

Loading...