Use gridLayout for repeater in DetailsText.
Now right mouse menu(copy) opens on label too.
Details
Details
Diff Detail
Diff Detail
- Repository
- R116 Plasma Network Management Applet
- Branch
- grid2 (branched from master)
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 23038 Build 23056: arc lint + arc unit
Comment Actions
Separate patch so can be easily reverted, if a grid+repeater problem exist R120:d12521b149fa.
Comment Actions
Even better than a GridLayout is a `Kirigami.FormLayout! That's what's being approximated here, so why not use the real thing? :)
Comment Actions
Do we need to reduce the opacity for the labels? We don't really do this anywhere else.
Comment Actions
Do we need to reduce the opacity for the labels?
The opacity was reduced in the layout update. IMO this is vital part of the new layout.
We don't really do this anywhere else.
This kind of layout is only used here.
edited for correctness.
Comment Actions
FormLayouts are used all over the place. But typically, we don't reduce the opacity of the labels. I'm not categorically against it, I'm just wondering. IIRC the labels were reduced opacity before, and this was not a change introduced with the 5.19 visual refresh.
@manueljlin and other VDG people, what do you think?
Comment Actions
Generally FormLayout is unfit for this, If I understand it correctly they cannot get theme.smallestFont height. Which will introduce big height, and big margins between lines.
IIRC the labels were reduced opacity before, and this was not a change introduced with the 5.19 visual refresh.
I'm not sure what you reffering to.
What I meant before, was the update of network manager for 5.19.
Comment Actions
Instead of kuserfeedback which uploads data collected prior users consent, I believe this patch is good enough. @ngraham It appears that I should let you know that, I'm no longer going to work on it under these circumstances, so that you can use it if you want.
@manueljlin D27199#629881 said it looks good as it is. Personally I'm not against full opacity, now with the different highlight and the highlight area restored, as it creates readability problem.