diff --git a/src/kcm/accounts.cpp b/src/kcm/accounts.cpp --- a/src/kcm/accounts.cpp +++ b/src/kcm/accounts.cpp @@ -29,9 +29,9 @@ AccountsSettings::AccountsSettings(QObject* parent, const QVariantList& args) : KQuickAddons::ConfigModule(parent, args) { - KAboutData* about = new KAboutData("kcm_kaccounts", i18n("Accounts"), - "1.0", QString(), KAboutLicense::LGPL); - about->addAuthor(i18n("Sebastian Kügler"), QString(), "sebas@kde.org"); + KAboutData* about = new KAboutData(QStringLiteral("kcm_kaccounts"), i18n("Accounts"), + QStringLiteral("1.0"), QString(), KAboutLicense::LGPL); + about->addAuthor(i18n("Sebastian Kügler"), QString(), QStringLiteral("sebas@kde.org")); setAboutData(about); } diff --git a/src/lib/createaccountjob.cpp b/src/lib/createaccountjob.cpp --- a/src/lib/createaccountjob.cpp +++ b/src/lib/createaccountjob.cpp @@ -73,7 +73,7 @@ } else { SignOn::IdentityInfo info; info.setCaption(m_providerName); - info.setAccessControlList(QStringList("*")); + info.setAccessControlList({QStringLiteral("*")}); info.setType(SignOn::IdentityInfo::Application); info.setStoreSecret(true); @@ -86,7 +86,7 @@ }); QVariantMap data = m_accInfo->authData().parameters(); - data.insert("Embedded", false); + data.insert(QStringLiteral("Embedded"), false); SignOn::SessionData sessionData(data); SignOn::AuthSessionP session = m_identity->createSession(m_accInfo->authData().method()); @@ -183,18 +183,18 @@ if (m_account->displayName().isEmpty()) { m_account->setDisplayName(info.userName()); } - m_account->setValue("username", info.userName()); + m_account->setValue(QStringLiteral("username"), info.userName()); m_account->setCredentialsId(info.id()); Accounts::AuthData authData = m_accInfo->authData(); - m_account->setValue("auth/mechanism", authData.mechanism()); - m_account->setValue("auth/method", authData.method()); + m_account->setValue(QStringLiteral("auth/mechanism"), authData.mechanism()); + m_account->setValue(QStringLiteral("auth/method"), authData.method()); - QString base("auth/"); + QString base = QStringLiteral("auth/"); base.append(authData.method()); - base.append("/"); + base.append(QLatin1Char('/')); base.append(authData.mechanism()); - base.append("/"); + base.append(QLatin1Char('/')); QVariantMap data = authData.parameters(); QMapIterator i(data); diff --git a/src/lib/getcredentialsjob.cpp b/src/lib/getcredentialsjob.cpp --- a/src/lib/getcredentialsjob.cpp +++ b/src/lib/getcredentialsjob.cpp @@ -81,7 +81,7 @@ return; } - authData["AccountUsername"] = acc->value(QLatin1String("username")).toString(); + authData[QStringLiteral("AccountUsername")] = acc->value(QLatin1String("username")).toString(); QPointer authSession = identity->createSession(authMethod.isEmpty() ? serviceAuthData.method() : authMethod); if (!authSession) { qWarning() << "Unable to create auth session for" << authMethod << serviceAuthData.method(); diff --git a/src/lib/uipluginsmanager.cpp b/src/lib/uipluginsmanager.cpp --- a/src/lib/uipluginsmanager.cpp +++ b/src/lib/uipluginsmanager.cpp @@ -133,7 +133,7 @@ s_instance->loadPlugins(); } - return s_instance->pluginsForNames.value(name + ".so"); + return s_instance->pluginsForNames.value(name + QStringLiteral(".so")); } KAccountsUiPlugin* UiPluginsManager::pluginForService(const QString &service)