Differential D27704

Drop FindAccountsFileDir.cmake
AbandonedPublic
Actions

Authored by nicolasfella on Feb 27 2020, 4:18 PM.

Details

Reviewers
bshah
leinir
lbeltrame
Group Reviewers
Frameworks
Commits
R155:17ff746ba128: Drop FindAccountsFileDir.cmake
Summary

no one is using it

Diff Detail

Repository
R155 KAccounts Integration
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
nicolasfella requested review of this revision.Feb 27 2020, 4:18 PM
nicolasfella created this revision.
leinir accepted this revision.Mar 9 2020, 9:46 AM

Removing unused stuff is always nice, well spotted :)

This revision is now accepted and ready to land.Mar 9 2020, 9:46 AM
Closed by commit R155:17ff746ba128: Drop FindAccountsFileDir.cmake (authored by nicolasfella). · Explain WhyMar 9 2020, 2:06 PM
This revision was automatically updated to reflect the committed changes.
lbeltrame reopened this revision.EditedMar 10 2020, 7:50 AM
lbeltrame added a subscriber: lbeltrame.

"No one using it" is not correct. Or at least, ACCOUNTS_SERVICES_DIR, set in that file, is used by the CMake macros, and it not existing will break builds (see KAccountsMacros.cmake). I'll revert the change (breaks building other projects), but probably it can be fixed if that variable is not used anywhere.

This revision is now accepted and ready to land.Mar 10 2020, 7:50 AM
lbeltrame requested changes to this revision.Mar 10 2020, 7:51 AM
This revision now requires changes to proceed.Mar 10 2020, 7:51 AM
nicolasfella abandoned this revision.Apr 14 2020, 3:20 PM

Revision Contents
Changeset List

Diff 77278

View Options

src/lib/CMakeLists.txt

Loading...
View Options

src/lib/cmake/CMakeLists.txt

Loading...
View Options

src/lib/cmake/FindAccountsFileDir.cmake

Loading...