Add an autotest for ActionToolBar
ClosedPublic

Authored by ahiemstra on Feb 27 2020, 12:56 PM.

Details

Summary

This adds an inital test to test whether ActionToolBar does the
right thing. It does not yet cover display hints or custom
components, but does cover using QQC2 action instead of Kirigami
Action.

Test Plan

The new test passes.

Diff Detail

Repository
R169 Kirigami
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ahiemstra created this revision.Feb 27 2020, 12:56 PM
Restricted Application added a project: Kirigami. · View Herald TranscriptFeb 27 2020, 12:56 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ahiemstra requested review of this revision.Feb 27 2020, 12:56 PM
apol added a subscriber: apol.Feb 27 2020, 2:22 PM
apol added inline comments.
src/CMakeLists.txt
80–81

Maybe pass different COMMAND to the same add_custom_command? As is it reads like you're declaring the command several times.

See https://cmake.org/cmake/help/v3.13/command/add_custom_command.html

ahiemstra retitled this revision from Change copy to binary to use a custom target that always runs to Add an autotest for ActionToolBar.Feb 27 2020, 3:38 PM
ahiemstra updated this revision to Diff 76556.Feb 27 2020, 3:44 PM
  • Don't use multiple commands to achieve what one can also do
ahiemstra added inline comments.Feb 27 2020, 3:45 PM
src/CMakeLists.txt
80–81

Good point. Done.

mart accepted this revision.Mar 2 2020, 11:39 AM
This revision is now accepted and ready to land.Mar 2 2020, 11:39 AM
This revision was automatically updated to reflect the committed changes.