WIP: Added top area to notification header
AbandonedPublic

Authored by niccolove on Feb 27 2020, 11:03 AM.

Details

Reviewers
broulik
ngraham
Summary

This is supposed to add a top area to floating notifications:


Looking good:

Also, this is also applied to notifications in the notification list, which should instead remain unchanged:

Depends on D27695

Diff Detail

Repository
R120 Plasma Workspace
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 23009
Build 23027: arc lint + arc unit
niccolove created this revision.Feb 27 2020, 11:03 AM
Restricted Application added a project: Plasma. · View Herald TranscriptFeb 27 2020, 11:03 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
niccolove requested review of this revision.Feb 27 2020, 11:03 AM
niccolove planned changes to this revision.Feb 27 2020, 11:04 AM
niccolove edited the summary of this revision. (Show Details)
This comment was removed by niccolove.
niccolove edited the summary of this revision. (Show Details)Feb 27 2020, 1:25 PM
niccolove updated this revision to Diff 76543.Feb 27 2020, 1:44 PM

Fix margins

niccolove edited the summary of this revision. (Show Details)Feb 27 2020, 1:45 PM
broulik requested changes to this revision.Feb 27 2020, 3:39 PM
broulik added a subscriber: broulik.

Also please Math.round when you divide sizes

applets/notifications/package/contents/ui/NotificationItem.qml
114–119

Plasma*Contents*?

This revision now requires changes to proceed.Feb 27 2020, 3:39 PM
niccolove updated this revision to Diff 76571.Feb 27 2020, 5:27 PM

Fixed margin

niccolove updated this revision to Diff 76672.Feb 29 2020, 10:13 AM

Fixed layouts

niccolove edited the summary of this revision. (Show Details)Feb 29 2020, 10:14 AM
niccolove updated this revision to Diff 76674.Feb 29 2020, 10:18 AM

Fix close button right margin

niccolove updated this revision to Diff 76825.Mar 3 2020, 9:23 AM

Components and rounding

niccolove marked an inline comment as done.Mar 3 2020, 9:23 AM
ngraham added a subscriber: ngraham.Mar 3 2020, 4:57 PM

Man this looks nice.

ngraham requested changes to this revision.Mar 9 2020, 5:54 PM

Looks sexy as hell. I think the icon inside the notification needs to be moved or resized though. Right now it has no top padding, so it touches the header.

applets/notifications/package/contents/ui/NotificationItem.qml
113–114

needs to be PlasmaExtras.PlasmoidHeading now, since it was renamed and moved to PlasmaExtras

This revision now requires changes to proceed.Mar 9 2020, 5:54 PM

Opened another one due to i-messed-up-arc-again: https://phabricator.kde.org/D27979

niccolove abandoned this revision.Mar 11 2020, 12:58 PM