[x11client] Make activity handling more consistent across windows
ClosedPublic

Authored by davidedmundson on Feb 27 2020, 1:00 AM.

Details

Summary

Typically by default newly added toplevel windows are added only to the
current activity.

Initially windows with no borders were added to all activities. This
causes problems particularly now with the newer frame extents support
leaving window behaviour quite inconsistent.

Since the time of the original code the taskbar gained control for
controlling activities allowing at least one method of changing them.
This means we can use this as the new filter.

BUG: 274931

Test Plan

Opened gtk3-demo
Switched activities, it wasn't on the new one
Went back, altered it through the taskmanager, it worked

Diff Detail

Repository
R108 KWin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
davidedmundson created this revision.Feb 27 2020, 1:00 AM
Restricted Application added a project: KWin. · View Herald TranscriptFeb 27 2020, 1:00 AM
Restricted Application added a subscriber: kwin. · View Herald Transcript
davidedmundson requested review of this revision.Feb 27 2020, 1:00 AM
zzag added a subscriber: zzag.Feb 27 2020, 10:25 AM

Initially windows with no borders were added to all activities

What's the reason behind doing it?

At the time the primary way to control activities was the window title bar - and if you can't control it being on everything is a safer default.
And to filter out utility windows

Relevant commits are d60077abdcf47ecfdc1345b4c81577c535b7d302
and this check added in ff82383f8d8acdc684468a3176e1d048a795209b

zzag accepted this revision.Feb 27 2020, 10:47 AM
This revision is now accepted and ready to land.Feb 27 2020, 10:47 AM
This revision was automatically updated to reflect the committed changes.