Show tooltip with full URL for URL button with overridden text
ClosedPublic

Authored by ngraham on Feb 25 2020, 9:39 PM.

Details

Summary

Normally the URLButton shows the full URL in its text. However if this text is overridden
to anything else, then the user can't know where the URL points, which may be worrisome,
and could be abused by malicious applications to obscure a hostile URL.

This patch implements a tooltip that shows the full URL when the text property has been
overridden and no longer shows the real URL.

Test Plan

Diff Detail

Repository
R169 Kirigami
Branch
conditionally-show-tooltip-on-url-button (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 22938
Build 22956: arc lint + arc unit
ngraham created this revision.Feb 25 2020, 9:39 PM
Restricted Application added a project: Kirigami. · View Herald TranscriptFeb 25 2020, 9:39 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ngraham requested review of this revision.Feb 25 2020, 9:39 PM
ndavis accepted this revision.Feb 25 2020, 11:26 PM
This revision is now accepted and ready to land.Feb 25 2020, 11:26 PM
ngraham edited the summary of this revision. (Show Details)Mar 6 2020, 6:17 PM
mart accepted this revision.Mar 6 2020, 6:19 PM
This revision was automatically updated to reflect the committed changes.