KAccounts was ported from QPluginLoader to KPluginLoader in D27633. Adapt the KAccounts plugin to stay compatible
Details
Details
- Reviewers
elvisangelaccio - Group Reviewers
KIO GDrive - Commits
- R219:088fe1964fcf: Adapt to new KAccounts plugin system
Added a google account. Got a notification that my drive can now be used
Diff Detail
Diff Detail
- Repository
- R219 KIO GDrive
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
The new plugin system will be released with the 20.04 release, so it would be good to have a kio-gdrive release with this fix at the same time
Comment Actions
LGTM but I cannot test it right now, signond keeps crashing for me (maybe Qt 5.15 fault).
And yes, time to do a new major release.
| kaccounts/kaccountsplugin.json | ||
|---|---|---|
| 4 | Is this string actually visible somewhere? If not I'd just remove, otherwise it will be extracted for translators (that would be a waste of effort). | |
Comment Actions
This change should have raised minimum KACCOUNTS_MIN_VERSION as it breaks with 19.12.3 and below.