Adapt to new KAccounts plugin system
ClosedPublic

Authored by nicolasfella on Feb 25 2020, 4:18 PM.

Details

Summary

KAccounts was ported from QPluginLoader to KPluginLoader in D27633. Adapt the KAccounts plugin to stay compatible

Test Plan

Added a google account. Got a notification that my drive can now be used

Diff Detail

Repository
R219 KIO GDrive
Branch
plugin
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 22919
Build 22937: arc lint + arc unit
nicolasfella requested review of this revision.Feb 25 2020, 4:18 PM
nicolasfella created this revision.
  • Add missing file

The new plugin system will be released with the 20.04 release, so it would be good to have a kio-gdrive release with this fix at the same time

  • Fix plugin id
elvisangelaccio accepted this revision.Mar 14 2020, 5:56 PM

LGTM but I cannot test it right now, signond keeps crashing for me (maybe Qt 5.15 fault).

And yes, time to do a new major release.

kaccounts/kaccountsplugin.json
4

Is this string actually visible somewhere? If not I'd just remove, otherwise it will be extracted for translators (that would be a waste of effort).

This revision is now accepted and ready to land.Mar 14 2020, 5:56 PM
This revision was automatically updated to reflect the committed changes.

This change should have raised minimum KACCOUNTS_MIN_VERSION as it breaks with 19.12.3 and below.

This change should have raised minimum KACCOUNTS_MIN_VERSION as it breaks with 19.12.3 and below.

Fixed with b55f433f25d6054a500ce3822442a605f536e5db.