Differential D27638

allow to take qqc2 actions and fix issues with it not having the visible prop
Needs ReviewPublic
Actions

Authored by camiloh on Feb 25 2020, 12:26 AM.

Details

Reviewers
ahiemstra
mart
Summary

This allows to correctly display the QQC2 Actions too, the issue was due to the loader source component not being picked as visible form parent loader and quering wrong the existance of the QQC2 visible prop

Test Plan

test it wiht K.Action and QQC2.Action. setting K.Action with the displayHint proprs and visible props and that QQC2 gets displayed, collapsed and respects the actiontoolbar display props

Diff Detail

Repository
R169 Kirigami
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 22884
Build 22902: arc lint + arc unit
camiloh created this revision.Feb 25 2020, 12:26 AM
Restricted Application added a project: Kirigami. · View Herald TranscriptFeb 25 2020, 12:26 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
camiloh requested review of this revision.Feb 25 2020, 12:26 AM
apol added a subscriber: apol.Feb 25 2020, 5:42 PM
apol added inline comments.
src/controls/ActionToolBar.qml
211

Isn't visible true by default?

src/controls/private/ActionToolBarLayoutDetails.qml
138

Indentation is broken.

Revision Contents
Changeset List

Diff 76336

View Options

src/controls/ActionToolBar.qml

Loading...
View Options

src/controls/private/ActionToolBarLayoutDetails.qml

Loading...