Config docs for Kicker, Kickoff, Task Manager, Pager, and the Desktop/Folder containment/widget.
ClosedPublic

Authored by hein on Sep 13 2016, 5:33 PM.

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
hein updated this revision to Diff 6701.Sep 13 2016, 5:33 PM
hein retitled this revision from to Config docs for Kicker, Kickoff, Task Manager, Pager, and the Desktop/Folder containment/widget..
hein updated this object.
hein edited the test plan for this revision. (Show Details)
hein added reviewers: Plasma, davidedmundson.
hein added a subscriber: plasma-devel.
Restricted Application added a project: Plasma. · View Herald TranscriptSep 13 2016, 5:33 PM
broulik added inline comments.
applets/kicker/package/contents/config/main.xml
32

preferred://, not preview

62

Deppenapostroph ;)

applets/kickoff/package/contents/config/main.xml
34

id's

applets/pager/package/contents/config/main.xml
27

What to do

applets/taskmanager/package/contents/config/main.xml
26

I was wondering, can't we expose the <choices> stuff in the docs? I fear this might easily get out of sync

38

id's

71

request (or ask) the window manager *to* highlight windows

75

preferred://

81

Are these shown in the docs?

containments/desktop/package/contents/config/main.xml
48

0 = No Label?

97

id's

101

Only works in popup (panel) mode?

131

Used "acting" before

hein marked 10 inline comments as done.Sep 13 2016, 6:01 PM
hein added inline comments.
applets/kicker/package/contents/config/main.xml
32

Fixed.

62

This is correct English orthography for pluralizing acronyms and abbreviations, see https://en.wikipedia.org/wiki/Apostrophe#Use_in_forming_some_plurals

applets/kickoff/package/contents/config/main.xml
34

False positive.

applets/pager/package/contents/config/main.xml
27

Fixed.

applets/taskmanager/package/contents/config/main.xml
26

This one has no <choices>.

38

Nope.

71

No, this is correct English grammar and the addition of "to" would actually make it wrong :). I'm too tired to remember the name of this grammatical construct atm, sorry ...

75

Fixed.

81

I don't know, but if they aren't the tool is not good enough yet since the XML has the information.

containments/desktop/package/contents/config/main.xml
48

Fixed.

97

Nope.

101

Added.

131

Fixed.

hein updated this revision to Diff 6705.Sep 13 2016, 6:01 PM
hein marked 10 inline comments as done.

Various fixes as requested.

davidedmundson added inline comments.Sep 13 2016, 6:16 PM
applets/taskmanager/package/contents/config/main.xml
81

they're not currently, but it's something fairly trivial to add that I intend to do now that this has some traction.

davidedmundson accepted this revision.Sep 13 2016, 6:16 PM
davidedmundson edited edge metadata.

Thanks

This revision is now accepted and ready to land.Sep 13 2016, 6:16 PM
This revision was automatically updated to reflect the committed changes.