Differential D27618

fix(kwayland): wait longer for connection timeout and retry
ClosedPublic
Actions

Authored by dvratil on Feb 24 2020, 9:43 AM.

Details

Reviewers

romangg

Group Reviewers

Plasma

Commits

R110:691c85879caf: fix(kwayland): wait longer for connection timeout and retry

Summary

During login creating the connection to Wayland server may take longer
than 1 second (KWin busy, high CPU and IO load, ...) causing
WaylandConfig to time out and leave the backend in an inconsistent
state.

This patch increases the timeout to 3 seconds and sets the overall
backend status to invalid if connecting to Wayland server times out.
This will abort the pending KScreen operation and prevent it from
interacting with the broken backend. The next KScreen operation
will try to set up the backend again, hopefully successfully this time.

BUG: 416566
FIXED-IN: 5.18.2

Diff Detail

Repository

R110 KScreen Library

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

dvratil created this revision.Feb 24 2020, 9:43 AM

Restricted Application added a project: Plasma. · View Herald TranscriptFeb 24 2020, 9:43 AM

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

dvratil requested review of this revision.Feb 24 2020, 9:43 AM

Harbormaster completed remote builds in B22845: Diff 76269.Feb 24 2020, 9:43 AM

dvratil edited the summary of this revision. (Show Details)Feb 24 2020, 12:04 PM

Thanks. This m_isValid variable was really uselsess. ;)

This revision is now accepted and ready to land.Feb 24 2020, 1:00 PM

Closed by commit R110:691c85879caf: fix(kwayland): wait longer for connection timeout and retry (authored by dvratil). · Explain WhyFeb 24 2020, 1:58 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			backends/kwayland/waylandbackend.h (1 line)
M			backends/kwayland/waylandbackend.cpp (3 lines)
M			backends/kwayland/waylandconfig.h (2 lines)
M			backends/kwayland/waylandconfig.cpp (14 lines)