Invert logic of shouldShowMountPoint -> ignoredMountPoint
ClosedPublic

Authored by bruns on Feb 23 2020, 10:52 PM.

Details

Summary

Instead of negating the logic values in several places, just invert
the logic. Also move it out of class, as it does not access any
class members.

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
bruns created this revision.Feb 23 2020, 10:52 PM
Restricted Application added a project: Plasma. · View Herald TranscriptFeb 23 2020, 10:52 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
bruns requested review of this revision.Feb 23 2020, 10:52 PM
bruns updated this revision to Diff 76251.Feb 23 2020, 11:31 PM

move out of class

usta added a subscriber: usta.Feb 23 2020, 11:36 PM

2 Question :
1- isnt that method should be const'ified ?
2- also its name will be much better isIgnoreableMountPoint (or something can be more understandable
that it will just return true or false ) becase right now it looks like
"ignore that mount point"

In D27611#616556, @usta wrote:

2 Question :
1- isnt that method should be const'ified ?

Its not a member function ...

bruns updated this revision to Diff 76253.Feb 23 2020, 11:43 PM

ignoreMountPoint -> ignoredMountPoint
whitespace

ngraham accepted this revision.Feb 24 2020, 5:03 PM
This revision is now accepted and ready to land.Feb 24 2020, 5:03 PM
bruns updated this revision to Diff 76329.Feb 24 2020, 11:12 PM
bruns retitled this revision from Invert logic of shouldShowMountPoint -> ignoreMountPoint to Invert logic of shouldShowMountPoint -> ignoredMountPoint.
bruns edited the summary of this revision. (Show Details)

Update commit message (I hate Phabricator)

This revision was automatically updated to reflect the committed changes.