Several not-interrelated minor changes that were pending
ClosedPublic

Authored by asensi on Feb 23 2020, 9:15 PM.

Details

Summary

In more detail:

  • Some adaptations due to the code style.
  • Some changes that @abika proposed in https://phabricator.kde.org/D24987.
  • Some comments were improved or added.
  • In one line: sym link was replaced with symlink, as in all the source code of Krusader.
  • A KMessageBox::sorry() is used the same way that it's utilized in void ListPanelFunc::editFile(const QUrl &filePath), where it's written KMessageBox::sorry(krMainWindow, i18n("You cannot edit a folder"));.

Diff Detail

Repository
R167 Krusader
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
asensi created this revision.Feb 23 2020, 9:15 PM
Restricted Application added a project: Documentation. · View Herald TranscriptFeb 23 2020, 9:15 PM
Restricted Application added a subscriber: kde-doc-english. · View Herald Transcript
asensi requested review of this revision.Feb 23 2020, 9:15 PM
gengisdave accepted this revision.Mar 3 2020, 7:15 AM
gengisdave added a subscriber: gengisdave.

Fine to me

This revision is now accepted and ready to land.Mar 3 2020, 7:15 AM

Well, thanks Davide and Alex!

This revision was automatically updated to reflect the committed changes.