Turn acceptsReservation into a ReserveAction
ClosedPublic
Actions

Authored by broulik on Feb 23 2020, 1:24 PM.

Details

Reviewers

Commits

Summary

According to [1] it can be the URL to a reservation page. Turn it into a ReserveAction to have a single code path for this on the consumer side.

Test Plan

Got a website with acceptsReservation URL and had a "Make a Reservation" button show up in p-b-i

Repository

R1003 KItinerary: Travel Reservation handling library

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Restricted Application added a subscriber: kde-pim. · View Herald Transcript

broulik requested review of this revision.Feb 23 2020, 1:24 PM

Maybe check for startsWith("https:")?

This revision is now accepted and ready to land.Feb 23 2020, 2:13 PM

broulik retitled this revision from RFC: Turn acceptsReservation into a ReserveAction to Turn acceptsReservation into a ReserveAction.

broulik edited the test plan for this revision. (Show Details)

Actually, it's only marked as String so it can be "Yes" and "No" as fallback, so it's either a bool (or convertible to one) or URL.

This revision is now accepted and ready to land.Feb 24 2020, 9:42 AM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			src/jsonldimportfilter.cpp (17 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	76217			Feb 23 2020, 1:23 PM	★	★
Diff 2	76223			Feb 23 2020, 2:56 PM	★	★
Diff 3	76268			Feb 24 2020, 9:41 AM	★	★
Diff 4	76280	8198987	R1003:0f8a2a4a5c3b796c4a781dda095206f1b971d7f9	Feb 24 2020, 12:20 PM	★	★