Set content to use available space.
Make scrollbars touch the side of the frame.
Fit speaker test grid inside the scrollview area.
Fix advanced content layout.
Make Header always fit inside the scrollview area.
BUG:416331
BUG:417447
Details
Details
- Reviewers
drosca ngraham - Group Reviewers
Plasma VDG - Commits
- R115:552b0384ffd2: [KCM]Fix content below scrollbars
Open audio settings from kickoff.
Before:
After:
Diff Detail
Diff Detail
- Repository
- R115 Plasma Audio Volume Applet
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
| src/kcm/package/contents/ui/Advanced.qml | ||
|---|---|---|
| 34 | What if there's too many devices? Also what does contentview refer to? | |
| src/kcm/package/contents/ui/Advanced.qml | ||
|---|---|---|
| 34 |
No matter how many devices there are, column is always a column.
That's why a TODO comment exist.
The width of the content. Need to remove "view". ContentWidth calculates most of the text with contentWidth instead of paintedWidth. | |
Comment Actions
Make scrollbars touch the side of the frame.
Fit speaker test grid inside the scrollview area.
Fix advanced content layout.
Make Header always fit inside the scrollview area.
Comment Actions
They are as related as the other 4 changes are.
Either will make 5 different patches or 1. But I'm not going to change back and forth.
Comment Actions
As far as I can tell, the other four changes are related to the scrollbar/view sizing/positioning. The other change to center labels may fix an issue, but it still represents a stylistic change. It should either be in a separate patch, or else it needs to be explicitly explained in the Summary and/or Description section.
Comment Actions
I would not call them stylistic choice, the position didn't change. And there are included in description.
Make Header always fit inside the scrollview area.
They had 2 different problems, when the text is too big.
As enabled they would cut text left and right.
And as disabled would make the page wide with vertical scrollbar.
And If I remember correctly, would display under the scrollbar.
The other change to center labels
They were already centered.
Comment Actions
Oops, my bad.
Seems like material for the stable branch. Have you gotten your developer account approved yet?
https://community.kde.org/Infrastructure/Phabricator#Landing_on_the_.22Stable_branch.22
Comment Actions
Today for 5.18.2 or can wait?
Apol only looked the code for the first change.
And I don't know why vertical margins create bind loop(Solved), or if Item as a proxy is good(found it in others areas too).
Comment Actions
Added item as a proxy for the devices and applications. This fixed the vertical binding loop.
And made scrollbar touch the top and botoom edges.
With this patch content is closer, by smallSpacing, to the frame.
And content touch top and bottom when scrolling.