Differential D27572

[kcm] Drop 'Enable bluetooth integration' setting
ClosedPublic
Actions

Authored by nicolasfella on Feb 22 2020, 12:55 PM.

Details

Reviewers
drosca
Group Reviewers
Plasma
Commits
R97:2d92acae05f4: [kcm] Drop 'Enable bluetooth integration' setting
Summary

It controls whether the bluedevil kded module is loaded. I don't see any use case for it. If one really really needs to disable the kded module this can be done from the kded KCM.

Diff Detail

Repository
R97 Bluedevil
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
nicolasfella created this revision.Feb 22 2020, 12:55 PM
Restricted Application added a project: Plasma. · View Herald TranscriptFeb 22 2020, 12:55 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
nicolasfella requested review of this revision.Feb 22 2020, 12:55 PM
broulik added a subscriber: broulik.Feb 22 2020, 1:55 PM

+1
Iirc the plasmoid is loaded regardless of that setting anyway?

drosca accepted this revision.Mar 12 2020, 6:51 AM

Applet doesn't need the KDED module, it only talks with BlueZ directly. This is for stuff like bluetooth:// kio protocol and receiving files.

What happens if someone have it disabled and updates Plasma with this change?

This revision is now accepted and ready to land.Mar 12 2020, 6:51 AM
nicolasfella added a comment.Mar 12 2020, 11:10 PM
In D27572#626285, @drosca wrote:

What happens if someone have it disabled and updates Plasma with this change?

Nothing immediately happens, but the module can be reenabled via the KDED KCM

Closed by commit R97:2d92acae05f4: [kcm] Drop 'Enable bluetooth integration' setting (authored by nicolasfella). · Explain WhyMar 14 2020, 7:14 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 77629

View Options

src/kcmodule/global/global.h

Loading...
View Options

src/kcmodule/global/global.cpp

Loading...
View Options

src/kcmodule/global/global.ui

Loading...