WebShortcuts Runner: Refactor foreach, remove unnecessary method
ClosedPublic

Authored by alex on Feb 22 2020, 6:54 AM.

Details

Summary

The foreach has been refactored and the loadSyntaxes method gets now called directly.
Additionally the cached (failed) key/provider can be reused for multiple sessions and is only cleared when the config changes.

Test Plan

Should compile and open urls as before.

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
alex created this revision.Feb 22 2020, 6:54 AM
Restricted Application added a project: Plasma. · View Herald TranscriptFeb 22 2020, 6:54 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
alex requested review of this revision.Feb 22 2020, 6:54 AM
alex updated this revision to Diff 76144.Feb 22 2020, 7:06 AM

Adjust comment

meven accepted this revision.Feb 22 2020, 8:56 AM

Seems good to me, wait for @broulik review

This revision is now accepted and ready to land.Feb 22 2020, 8:56 AM
broulik accepted this revision.Mar 24 2020, 8:03 AM
broulik added inline comments.
runners/webshortcuts/webshortcutrunner.cpp
79

Coding style: put space before {

alex updated this revision to Diff 78338.Mar 24 2020, 8:33 AM

Coding style: put space before {

alex marked an inline comment as done.Mar 24 2020, 8:34 AM
This revision was automatically updated to reflect the committed changes.