Hide configure action in Info center mode
ClosedPublic

Authored by ngraham on Feb 22 2020, 5:55 AM.

Details

Summary

There's nothing to configure, so hide the action that shows the configuration window.

BUG: 417977
BUG: 417981
FIXED-IN: 5.19.0

Test Plan

Open Info Center
Click on hamburger menu
No more Configure... menu item

Diff Detail

Repository
R124 System Settings
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ngraham created this revision.Feb 22 2020, 5:55 AM
Restricted Application added a project: Plasma. · View Herald TranscriptFeb 22 2020, 5:55 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ngraham requested review of this revision.Feb 22 2020, 5:55 AM

Wouldnt it be better to just hide the configure action where it's created?

Wouldnt it be better to just hide the configure action when it's created?

ngraham edited the summary of this revision. (Show Details)Feb 22 2020, 4:36 PM

Not sure about that, since it's shown in icons view too. So we would need to conditionally show it for icons+systemsettings view and sidebar+systemsettings view. This patch just hides it for sidebar+kinfocenter view, which seems simpler to me.

Or maybe I'm misunderstanding you?

To translate Kai:

When we create the action we can call setVisible false in the one mode. Rather than here

Advantage is that then any shortcuts also won't work.

ngraham updated this revision to Diff 77596.Fri, Mar 13, 7:19 PM

I hate you arc

ngraham updated this revision to Diff 77597.Fri, Mar 13, 7:24 PM

Or maybe I just hate myself

Okay, this should be saner now.

davidedmundson accepted this revision.Fri, Mar 13, 7:34 PM
This revision is now accepted and ready to land.Fri, Mar 13, 7:34 PM
This revision was automatically updated to reflect the committed changes.