| mart |
| Plasma |
Plasma::PluginLoader::self()->listAppletInfo(QString() is expensive, it
loads and parses every .desktop file individually. Twice.
The main offender is the defaultApplets property, which gets requested
multiple times from JS space, and we reparse the files every time.
Moving the work to the constructor solves that. This saves loading (on
my machine) ~900 desktop files.
Running "time plasmashell" shows:
BEFORE:
plasmashell 4.01s user 0.46s system 87% cpu 5.116 total
plasmashell 4.01s user 0.54s system 74% cpu 6.124 total
AFTER:
plasmashell 3.17s user 0.42s system 68% cpu 5.259 total
plasmashell 3.18s user 0.46s system 81% cpu 4.475 total
| Automatic diff as part of commit; lint not applicable. |
| Automatic diff as part of commit; unit tests not applicable. |
| applets/systemtray/systemtray.cpp | ||
|---|---|---|
| 390–393 | Don't iterate over values(), you're creating a temporary QList just to iterate over it: for (auto it = m_systrayApplets.constBegin(); end = m_systrayAppltes.constEnd(); it != end; ++it) {
const KPluginInfo &info = it.value();
...
} | |
| applets/systemtray/systemtray.cpp | ||
|---|---|---|
| 102 | maybe better not to put new q_foreach as is going to be deprecated? | |