Differential D27554

reviews: expose the reviewed package version on the delegate
ClosedPublic
Actions

Authored by apol on Feb 21 2020, 8:06 PM.

Details

Reviewers
None
Group Reviewers
Plasma
VDG
Commits
R134:d58668698f5f: reviews: expose the reviewed package version on the delegate
Summary

Helps show which version was reviewed to see if the critiques might have
been figured out.

BUG: 417675

Diff Detail

Repository
R134 Discover Software Store
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
apol created this revision.Feb 21 2020, 8:06 PM
Restricted Application added a project: Plasma. · View Herald TranscriptFeb 21 2020, 8:06 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
apol requested review of this revision.Feb 21 2020, 8:06 PM
ngraham added a reviewer: VDG.Feb 21 2020, 8:09 PM
ngraham added a subscriber: ngraham.

Nice! How about putting the version next to the stars, up on the header row?

apol added a comment.Feb 21 2020, 8:11 PM
In D27554#615412, @ngraham wrote:

Nice! How about putting the version next to the stars, up on the header row?

Having 2 text fields growing one against each other is often a source of problems. Could work though.

This revision was not accepted when it landed; it landed in state Needs Review.Feb 27 2020, 2:50 PM
Closed by commit R134:d58668698f5f: reviews: expose the reviewed package version on the delegate (authored by apol). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 76549

View Options

discover/qml/ReviewDelegate.qml

Loading...
View Options

libdiscover/ReviewsBackend/ReviewsModel.h

Loading...
View Options

libdiscover/ReviewsBackend/ReviewsModel.cpp

Loading...