Differential D27545

Escape connection name in close dialog
ClosedPublic
Actions

Authored by davidedmundson on Feb 21 2020, 12:14 PM.

Details

Reviewers
jgrulich
Group Reviewers
Plasma
Commits
R116:28c36476fc3b: [kcm] Escape connection name in close dialog
Summary

Due to MessageDialog being used we cannot change the text format on the
label, therefore we have to escape the connection name.

This expression is copied from plasma-framework internals.

Test Plan

Set my ssid to foo<b>123</b>
Tried to remove the SSID
No bold text anymore

Diff Detail

Repository
R116 Plasma Network Management Applet
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
Restricted Application added a project: Plasma. · View Herald TranscriptFeb 21 2020, 12:14 PM
Restricted Application added a reviewer: jgrulich. · View Herald Transcript
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
davidedmundson requested review of this revision.Feb 21 2020, 12:14 PM
jgrulich accepted this revision.Feb 21 2020, 12:21 PM
This revision is now accepted and ready to land.Feb 21 2020, 12:21 PM
Closed by commit R116:28c36476fc3b: [kcm] Escape connection name in close dialog (authored by davidedmundson). · Explain WhyFeb 21 2020, 12:41 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mkcm/qml/main.qml (13 lines)

Diff 76101

View Options

kcm/qml/main.qml

Loading...