Touchpad KDED: fix metadata warning

Authored by davidedmundson on Sep 12 2016, 4:17 PM.


Group Reviewers

Get rid of kded warning:
kf5.kded: found kded module "touchpad" by prepending 'kded_' to the library path, please fix your metadata

Test Plan

Log out and in again, warning disappeared, everything works ok - specifically kded disables touchpad while typing.

Diff Detail

R119 Plasma Desktop
Lint Skipped
Unit Tests Skipped
knambiar updated this revision to Diff 6670.Sep 12 2016, 4:17 PM
knambiar retitled this revision from to Touchpad KDED: fix metadata warning.
knambiar updated this object.
knambiar edited the test plan for this revision. (Show Details)
knambiar added a reviewer: Plasma.
knambiar set the repository for this revision to R119 Plasma Desktop.
Restricted Application added a project: Plasma. · View Herald TranscriptSep 12 2016, 4:17 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
davidedmundson accepted this revision.Sep 13 2016, 11:30 AM
davidedmundson added a reviewer: davidedmundson.
This revision is now accepted and ready to land.Sep 13 2016, 11:30 AM
mart accepted this revision.Sep 13 2016, 11:32 AM
mart added a reviewer: mart.

Thanks for the review, but actually I am not convinced that this gets rid of the warning message. Sifting through the KF5 porting notes, I am not sure how this should be handled -- kded tries to load the plugin with just "name" and if not found it looks for "kded_name", which succeeds and emits this warning.
Any suggestions what should be the right approach with KPluginLoader? Should it be always fed with JSON plugin metadata?

aacid requested changes to this revision.Sep 5 2017, 8:27 PM
aacid added a subscriber: aacid.

So what's the status of this? needs landing? needs help?

This revision now requires changes to proceed.Sep 5 2017, 8:27 PM
knambiar updated this revision to Diff 19300.Sep 8 2017, 9:03 AM
knambiar edited edge metadata.
In D2754#143319, @aacid wrote:

So what's the status of this? needs landing? needs help?

Thanks for offering the help, Albert!
Trouble here is that the error is not reproducible. The last message in my logs is from Sep 04 (prior to that was Aug 22), so there isn't an easy way to ensure that this change fixes the issue.
That said, going through other modules and similar error messages; I've another patch hopefully more correct. Could you review the updated version?

aacid added a comment.Sep 9 2017, 4:19 PM

I can try having a look, not a mega expert myself though

davidedmundson commandeered this revision.Nov 16 2018, 11:54 AM
davidedmundson edited reviewers, added: knambiar; removed: davidedmundson.

This was merged at some point
Closing the RR.

davidedmundson abandoned this revision.Nov 16 2018, 11:54 AM