| mart |
| Plasma: Design | |
| Plasma |
This cleans up the UI by moving the wallpaper configuration to a separate tab and also gives it more room.
It uses a documentMode TabWidget (no frame) as it has a lighter color and I couldn't find an equivalent in QPalette to make QQuickWidet blend in there.
Also take into account QtQuick Layouts hardcoded default spacing of 5px to make ComboBoxes aligned.
Just shuffled widgets around, still works. Wallpaper config expands to full dialog height now :)
While at it added a colon to the "lock screen on resume" label
Doc about hardcoded spacing: https://doc.qt.io/qt-5/qml-qtquick-layouts-rowlayout.html#spacing-prop
| Automatic diff as part of commit; lint not applicable. |
| Automatic diff as part of commit; unit tests not applicable. |
Indeed the idea was to use a longer, scrolling page instead of tabs, combined with expanding sections for advanced settings.
What made you choose tabs, Kai?
Because that's an idea Martin and I had a while ago iirc. And also I don't see how we could make this one scrolling page, since it's a QML thing with a ScrollView embedded in a widget environment.
Then I'd recommend using the tabs for now, and then with the next iteration reimplement the whole KCM in QML(and not having the wallpaper selection in its own scroll view, but putting it all on one big page that scrolls.
i'm not sure how it could work however, would look relly weird.
i think iwould already prefer opening a separate dialog upon a "chose wallpaper" action