Support Qt 5.14 on Android
ClosedPublic

Authored by vkrause on Feb 20 2020, 5:06 PM.

Details

Summary

Assets (QML files and icons) are no longer extracted into the file system,
but now are available in the android_rcc_bundle QRC file.

This is based on Francis' work mentioned in D26749, but slightly adjusted
to also fix icon loading as well.

Diff Detail

Repository
R169 Kirigami
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
vkrause created this revision.Feb 20 2020, 5:06 PM
Restricted Application added a project: Kirigami. · View Herald TranscriptFeb 20 2020, 5:06 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
vkrause requested review of this revision.Feb 20 2020, 5:06 PM
apol added a subscriber: apol.EditedFeb 21 2020, 1:22 AM

Assets (QML files and icons) are no longer extracted into the file system,
but now are available in the android_rcc_bundle QRC file.

Meaning that we now need to change all applications to put the resources on the rcc file?

The change upstream seems bonkers to me. Whatever, let's get this in. We'll possibly need to patch quite many apps for this... :(

Also feels quite weird how the commit message is twice the same text but it never says why it's done. https://codereview.qt-project.org/c/qt/qtbase/+/270573/24

¯\_(ツ)_/¯

In D27525#614905, @apol wrote:

Assets (QML files and icons) are no longer extracted into the file system,
but now are available in the android_rcc_bundle QRC file.

Meaning that we now need to change all applications to put the resources on the rcc file?

No, androiddeployqt does that on its own. So overall the apk still has exactly the same content, just the way to access it changed. It is possible apps make assumption about this, some of the frameworks definitely do.

The change upstream seems bonkers to me. Whatever, let's get this in. We'll possibly need to patch quite many apps for this... :(

Also feels quite weird how the commit message is twice the same text but it never says why it's done. https://codereview.qt-project.org/c/qt/qtbase/+/270573/24

¯\_(ツ)_/¯

It's avoiding duplicating the assets again in the file system, thus needing less space and significantly speeding up the first start. So while technically going in the right direction I would certainly have preferred to have this as something opt-in to not break all existing non-trivial code out there...

mart accepted this revision.Feb 26 2020, 1:30 PM
This revision is now accepted and ready to land.Feb 26 2020, 1:30 PM
This revision was automatically updated to reflect the committed changes.