Differential D27524

Fix qCompare between strings.
ClosedPublic
Actions

Authored by TallFurryMan on Feb 20 2020, 4:50 PM.

Details

Reviewers
mutlaqja
Commits
R321:2f836ac57982: Fix qCompare between strings.
Summary

Hotfix for a potential incompatibility with old Qt?
The test code was qCompare'ing a QString with a const char pointer, and depending on the platform, was successfully casting between those, or not.

Test Plan

None, this fixes a compile issue.

Diff Detail

Repository
R321 KStars
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
TallFurryMan created this revision.Feb 20 2020, 4:50 PM
Restricted Application added a project: KDE Edu. · View Herald TranscriptFeb 20 2020, 4:50 PM
Restricted Application added a subscriber: kde-edu. · View Herald Transcript
TallFurryMan requested review of this revision.Feb 20 2020, 4:50 PM
mutlaqja accepted this revision.Feb 20 2020, 5:00 PM
This revision is now accepted and ready to land.Feb 20 2020, 5:00 PM
Closed by commit R321:2f836ac57982: Fix qCompare between strings. (authored by TallFurryMan, committed by mutlaqja). · Explain WhyFeb 20 2020, 5:01 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
MTests/kstars_ui/test_ekos.cpp (4 lines)

Diff 76059

View Options

Tests/kstars_ui/test_ekos.cpp

Loading...