BUG: 417882
Not tested yet !
Details
Details
Diff Detail
Diff Detail
- Repository
- R128 User Manager
- Branch
- master
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 22705 Build 22723: arc lint + arc unit
Comment Actions
Review without knowing very well the codebase.
| src/lib/accountmodel.cpp | ||
|---|---|---|
| 181 | Remove? | |
| src/lib/accountmodel.h | ||
| 64 | Q_ENUM is useful for these, especially since you use them with qDebug. | |
| 71 | I'm not very familiar with the code. Are you sure setData wasn't called elsewhere? The one you changed was an overriden virtual. In fact, if you're changing it, you can use more adequate API like you don't need to pass the Qt::EditRole. | |