The ShellConfig class has been deleted. This config class was in KDE4 for the runOptions widget used and the class/the settings are not used anymore.
Additionally the context type check has been removed, because this is already solved using the ignore types.
Futhermore the match icon and the list of actions can be reused.
Details
Details
- Reviewers
davidedmundson ngraham broulik meven - Group Reviewers
Plasma - Commits
- R120:86fd0f2f7176: Remove unnecessary code and function calls
Should compile and execute shell commands as before.
Diff Detail
Diff Detail
- Repository
- R120 Plasma Workspace
- Branch
- shellrunner_cleanup
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 22687 Build 22705: arc lint + arc unit
| runners/shell/shellrunner.cpp | ||
|---|---|---|
| 67–68 | you can remove this line | |
Comment Actions
Cleanup is good.
Futhermore the match icon and the list of actions can be reused.
I don't think these changes really bring anything.
Icon's are cached at the layer beneath (with a proper QCache with expunging) and actionsForMatch is called so rarely that doing:
return actions().values();
Will be just as performant in practical terms.
Comment Actions
Thanks for the feedback.
The actionsForMatch method gets actually called very often, I debugged this by adding qWarning() << match.text(); as a debug statement in the method.
But I guess that I can keep the changes.