Results in window title consistent with name in desktop file and appdata
package name
Details
Details
Diff Detail
Diff Detail
- Repository
- R355 KDebugSettings
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
It is a typo though in the original string, which is displayed as such for American English or without a translation available. Those have been fixed all the time before, without needing an exception.
@aacid Can you confirm?
Comment Actions
Those have been fixed all the time before, without needing an exception.
Sure, in master branches when there is no string freeze -- which means you can change this in master.
A aifferent matter is release/19.12, which is a feature- and string-frozen branch.
So NACK: this change is merely cosmetics, and it is the title of a debugging tool even.
Comment Actions
The original string is "kdebugssettings" (see the double s, it#s not just about casing). Do you think this also means "cosmetics"? It hurt my eyes often enough now that I went for fixing ;)
Comment Actions
Sure, I see the typo in the string. The string was introduced like this with commit c771032a0fb2f7db51330d335a31c2c40b406509, which is now 5 years old: this means that nobody noticed for 5 years, and that it is still nothing more than a cosmetic issue.
The above, plus the fact that it is a developer tool, makes this fix material for master only, and not a strong reason to break the string freeze.
Comment Actions
I would change "nobody noticed" to "nobody bothered enough". Okay, tried to make my case, will continue wearing eye protection until 20.04 then.
kdebugsettings might also be considered additionally a user-support tool, to be run by users when they are asked to report some logging for something the developer/bug assignee cannot reproduce. (Edit: and even as developer I prefer my tools to look sexy and flawless, so that argument does not go well with me)