Update kdeglobals config file for Breeze widgetStyle
ClosedPublic

Authored by crossi on Feb 18 2020, 5:00 PM.

Details

Summary

Following D27407 provide kconf update script to fix user configuration for widgetStyle when Breeze global theme is applied

Test Plan

In kdeglobals, group KDE, shoud replace the entry widgetStyle=breeze with widgetStyle=Breeze, otherwise does nothing.
Then, in KCM Application Style, Breeze style should be highlighted/selected.

Diff Detail

Repository
R119 Plasma Desktop
Lint
Lint Skipped
Unit
Unit Tests Skipped
Build Status
Buildable 22641
Build 22659: arc lint + arc unit
crossi created this revision.Feb 18 2020, 5:00 PM
Restricted Application added a project: Plasma. · View Herald TranscriptFeb 18 2020, 5:00 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
crossi requested review of this revision.Feb 18 2020, 5:00 PM
crossi edited the test plan for this revision. (Show Details)Feb 18 2020, 5:03 PM
crossi added reviewers: ngraham, ervin, bport, meven, Plasma.
crossi edited the test plan for this revision. (Show Details)Feb 18 2020, 5:10 PM

How do I trigger this to get run? Restarting plasmashell or opening the Style KCM didn't seem to do it.

How do I trigger this to get run? Restarting plasmashell or opening the Style KCM didn't seem to do it.

To run the update script, just apply the patch and rebuild plasma-desktop.

To confirm it has run in .config/kconf_updaterc at the end you will see

[style_widgetstyle_default_breeze.upd]
done=StyleWidgetStyleDefaultBreeze,StyleRemoveGeneralWidgetStyle

And in .config/kdeglobals should have updated widgetStyle entry in group KDE

crossi added a comment.EditedFeb 18 2020, 5:35 PM

This fix the issue for Breeze theme, but according to bug description (https://bugs.kde.org/show_bug.cgi?id=417515) some configuration file may also have oxygen instead of Oxygen and maybe the case for fusion and window them style.

How do I trigger this to get run? Restarting plasmashell or opening the Style KCM didn't seem to do it.

To run the update script, just apply the patch and rebuild plasma-desktop.

Did that.

To confirm it has run in .config/kconf_updaterc at the end you will see

[style_widgetstyle_default_breeze.upd]
done=StyleWidgetStyleDefaultBreeze,StyleRemoveGeneralWidgetStyle

I see the following:

[style_widgetstyle_default_breeze.upd]
ctime=1582046255
done=StyleWidgetStyleDefaultBreeze
mtime=1582046231

And in .config/kdeglobals should have updated widgetStyle entry in group KDE

I still see widgetStyle=breeze (not capitalized) in the file. :(

Weird, I've tested again, and works like expected on my machine.

Is it the widgetStyle entry from KDE group ?

I have also an entry named widgetStyle in group General but we are not interested in that one.

bport added inline comments.Feb 19 2020, 9:38 AM
kcms/style/style_widgetstyle_default_breeze.pl
8

This will fix only for Breeze theme
This will fix existing case but we also need to fix the root cause (i.e. how we end up with a lowercase name).

meven accepted this revision.Feb 19 2020, 10:02 AM

Works : replace widgetStyle in group KDE and selects the application style in systemsettings; Does not edit widgetStyle in group General

+1 on fixing whatever lowercased the value in the first place. Comment by @bport

This revision is now accepted and ready to land.Feb 19 2020, 10:02 AM

Works : replace widgetStyle in group KDE and selects the application style in systemsettings; Does not edit widgetStyle in group General

Thanks for the confirmation.

+1 on fixing whatever lowercased the value in the first place. Comment by @bport

Fixed by D27407

@ngraham do you confirm it is not working ?

I think I did--for me at least. But I won't block this because I'm not sure if my kdesrc-build-built setup is capable of testing kconfig patches adequately.

ervin added inline comments.Feb 24 2020, 12:36 PM
kcms/style/style_widgetstyle_default_breeze.pl
8

Sure but that would be a different patch isn't it? (both should be rolled out together though)

Now I wonder if there are more than "breeze" that we'd like to fix in the process? Just to avoid having several config updates to deploy.

crossi added inline comments.Feb 25 2020, 10:04 AM
kcms/style/style_widgetstyle_default_breeze.pl
8

Root cause was fixed by D27407

This patch will allow to fix faulty configuration file without requiring the user to re-apply Breeze Style as chatted in aforementioned patch.

Currently, this is the only faulty breeze I see, others KCM looks ok.

ervin accepted this revision.Feb 25 2020, 2:43 PM
This revision was automatically updated to reflect the committed changes.