Differential D27472

[plasma-session] Cleanup StartServiceJob
AbandonedPublic
Actions

Authored by davidedmundson on Feb 18 2020, 10:18 AM.

Details

Reviewers
apol
Group Reviewers
Plasma
Summary

Mostly just a code cleanup, also uses the correct version of
startDetached

Test Plan

Logged out/ logged in

Diff Detail

Repository
R120 Plasma Workspace
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 22619
Build 22637: arc lint + arc unit
Restricted Application added a project: Plasma. · View Herald TranscriptFeb 18 2020, 10:18 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
davidedmundson requested review of this revision.Feb 18 2020, 10:18 AM
apol accepted this revision.Feb 18 2020, 12:10 PM
apol added a subscriber: apol.
apol added inline comments.
startkde/plasma-session/startup.cpp
438

Are you sure showing an error message on error is not useful anymore?

This revision is now accepted and ready to land.Feb 18 2020, 12:10 PM
davidedmundson added inline comments.Feb 18 2020, 12:21 PM
startkde/plasma-session/startup.cpp
438

we have one on the startDetached retun value.

once we double fork and detach I didn't think we would get any other warnings.

davidedmundson abandoned this revision.Feb 18 2020, 12:50 PM

Turns out this is fixing up something that changed in the non-merged patch.

I may as well squash it there.

Revision Contents
Changeset List

Diff 75903

View Options

startkde/plasma-session/startup.h

Loading...
View Options

startkde/plasma-session/startup.cpp

Loading...