[plasma-session] Avoid potential race condition starting a service
ClosedPublic
Actions

Authored by davidedmundson on Feb 18 2020, 10:06 AM.

Details

Reviewers

apol

Group Reviewers

Plasma

Commits

Summary

If for some reason a service is started before StartServiceJob runs, we
will end up blocking forever.

Test Plan

Logged in

Repository

R120 Plasma Workspace

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

I think for 5.18

This revision is now accepted and ready to land.Feb 18 2020, 12:08 PM

This revision was automatically updated to reflect the committed changes.

broulik added inline comments.

startkde/plasma-session/startup.cpp
429	Could probably use an `m_service.isEmpty()` check since it will still needlessly do a `NameHasOwner` call

startkde/plasma-session/startup.cpp
429	All usages of this class (which is just the 1 case to start ksmserver!) have a name passed. Without a name it wouldn't ever finish.

			Path	Packages
M			startkde/plasma-session/startup.h (1 line)
M			startkde/plasma-session/startup.cpp (9 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	75902	bb638c3		Feb 18 2020, 10:06 AM	★	★
Diff 2	75907	285155f	R120:854b64fc130b8e1c3a254bf087bb162616cc8041	Feb 18 2020, 12:40 PM	★	★