Set good default value for cursor theme and size in KRDB
ClosedPublic

Authored by bport on Feb 18 2020, 9:01 AM.

Details

Diff Detail

Repository
R119 Plasma Desktop
Lint
Lint Skipped
Unit
Unit Tests Skipped
Build Status
Buildable 22615
Build 22633: arc lint + arc unit
bport created this revision.Feb 18 2020, 9:01 AM
Restricted Application added a project: Plasma. · View Herald TranscriptFeb 18 2020, 9:01 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
bport requested review of this revision.Feb 18 2020, 9:01 AM
meven accepted this revision.Feb 18 2020, 9:07 AM

This looks like a good kcms to convert to KConfigXT...

kcms/krdb/krdb.cpp
756

0 is unintuitive, it is for "default"/autodetermined I guess.

This revision is now accepted and ready to land.Feb 18 2020, 9:07 AM

This looks like a good kcms to convert to KConfigXT...

This isn't even a kcm :D
See Kai's mail to plasma-devel
https://mail.kde.org/pipermail/plasma-devel/2020-February/110655.html

This is not a KCM, and because of how stuff works with KRDB we can't reuse kcfg easily there (because build by 5 or 6 kcm)
About the 0 as default value, perhaps we can change that but it's totally unrelated to this patch, goal there is only to honor default value as set by kcfg

davidedmundson accepted this revision.Feb 18 2020, 10:37 AM
crossi accepted this revision.Feb 18 2020, 10:45 AM
ngraham edited the summary of this revision. (Show Details)Feb 18 2020, 4:49 PM
ngraham edited the summary of this revision. (Show Details)

Can you run arc amend on your local branch to pick up the changes I just made to the description, and then land this on the stable branch?

This revision was automatically updated to reflect the committed changes.