In wayland, QScreen::availableGeometry() returns QScreen::geometry(), we could get a better value from plasmashell
BUG: 386114
Details
Details
- Reviewers
davidedmundson - Group Reviewers
Plasma - Commits
- R120:731a19081044: Set a better position for Krunner in wayland
Krunner isn't overlapped by a top panel in all cases
Diff Detail
Diff Detail
- Repository
- R120 Plasma Workspace
- Branch
- master
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 22611 Build 22629: arc lint + arc unit
Comment Actions
+1 on fixing this
| krunner/view.cpp | ||
|---|---|---|
| 239 | This is a blocking call, it would be ideal to find a way around this... | |
Comment Actions
Idea is nice.
Does this not jitter on first load? Starting off in 0,0 then moving across?
We now have position async() but we're doing that after we've shown the window.
Comment Actions
Does this not jitter on first load? Starting off in 0,0 then moving across?
We now have position async() but we're doing that after we've shown the window.I don't think so. The show() is in the callback.
/A/ show() is there. It seems to be absolutely useless.
We call show in View::display()
Then we position on showEvent or resizeEvent
This comment was removed by trmdi.
Comment Actions
Lets go for it.
| krunner/view.cpp | ||
|---|---|---|
| 412 | this is a very confusing name. It refers to the visible state krunner has set, but most importantly NOT the state of the QWindow (which is arguably the real state) | |