Differential D27443

Fix setting translation domain on the Grantlee localizer
ClosedPublic
Actions

Authored by vkrause on Feb 16 2020, 7:30 PM.

Details

Reviewers
aacid
mlaurent
Commits
R94:139ef5a0f624: Fix setting translation domain on the Grantlee localizer
Summary

GrantleeTheme::Engine::localizer is a factory function, so calling
methods on a temporary returned by it has no effect.

Diff Detail

Repository
R94 PIM: Message Library
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
vkrause created this revision.Feb 16 2020, 7:30 PM
Restricted Application added a project: KDE PIM. · View Herald TranscriptFeb 16 2020, 7:30 PM
Restricted Application added a subscriber: kde-pim. · View Herald Transcript
vkrause requested review of this revision.Feb 16 2020, 7:30 PM
mlaurent accepted this revision.Feb 16 2020, 8:18 PM
This revision is now accepted and ready to land.Feb 16 2020, 8:18 PM
Closed by commit R94:139ef5a0f624: Fix setting translation domain on the Grantlee localizer (authored by vkrause). · Explain WhyFeb 17 2020, 5:26 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 75848

View Options

messageviewer/src/messagepartthemes/default/messagepartrenderermanager.cpp

Loading...