Use task rather than tabs
Needs RevisionPublic

Authored by niccolove on Feb 16 2020, 4:29 PM.

Details

Reviewers
ngraham
ndavis
broulik
Group Reviewers
VDG
Summary

Switch from tabs for pressed applets to tasks.

  • Tabs should be avoided because it's quite semantically incorrect and I need to change tab style in another patch to make them look prettier but that would break clicked plasmoids
  • Tasks appearance is consistent with the system tray that's next to it; plus, I think that it looks prettier than just a line.

Alternatively, a hover view-item effect could be used, especially since the panel margin could be higher in third party themes.

Test Plan

Before:


After:

I could investigate making it stretch to the borders:

Diff Detail

Repository
R119 Plasma Desktop
Branch
avoid_tabs_for_applets (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 22538
Build 22556: arc lint + arc unit
niccolove created this revision.Feb 16 2020, 4:29 PM
Restricted Application added a project: Plasma. · View Herald TranscriptFeb 16 2020, 4:29 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
niccolove requested review of this revision.Feb 16 2020, 4:29 PM
niccolove edited the test plan for this revision. (Show Details)Feb 16 2020, 4:31 PM
niccolove edited the summary of this revision. (Show Details)
niccolove edited the test plan for this revision. (Show Details)
niccolove added a reviewer: VDG.

To make it stretch to the borders, simply just remove padding from panel.svgz and from the Plasmoid highlight SVG.

To make it stretch to the borders, simply just remove padding from panel.svgz and from the Plasmoid highlight SVG.

But themes should be able to set their padding, I can't just remove it. Rather, I was trying to give the effect a negative margin equal to the panel margin size.

...but that does not seem simple and would be inconsistent with the task view, so we might want to leave that for another patch

niccolove edited the summary of this revision. (Show Details)Feb 16 2020, 4:49 PM
ngraham accepted this revision.Feb 16 2020, 4:50 PM
ngraham added a subscriber: ngraham.

This is more semantically correct and a visual improvement IMO. Looks fine to me with Breeze dark and light but we should probably wait for confirmation from heavy Breeze Dark users.

I think it's fine as-is with the built-in margins, though removing them in the SVG is fine; changing the appearance of the plasma theme SVGs doesn't impact third-party themes at all. And obviously that needs to be done in a separate patch anyway since the SVG lives in a different repo.

This revision is now accepted and ready to land.Feb 16 2020, 4:50 PM

Actually, after some use, I don't think this is the best effect to use. I will investigate more.

broulik requested changes to this revision.Mar 9 2020, 2:24 PM
broulik added a subscriber: broulik.

This will utterly break with every third party theme.
If we were to do this we would need to introduce a dedicated "applet is open" highlight item or some property to tell it to use tasks for that purpose.

This revision now requires changes to proceed.Mar 9 2020, 2:24 PM