[KRDB] Rename GTK colours to be exported

Authored by cblack on Feb 15 2020, 4:35 PM.



The colours exported by KRDB for GTK now have the _breeze suffix.

BUG: 417461
FIXED-IN: 5.19

Test Plan

In tandem with D27425, no visual change should be expected.

Diff Detail

R119 Plasma Desktop
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.
cblack created this revision.Feb 15 2020, 4:35 PM
Restricted Application added a project: Plasma. · View Herald TranscriptFeb 15 2020, 4:35 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
cblack requested review of this revision.Feb 15 2020, 4:35 PM
ngraham accepted this revision.Feb 15 2020, 6:02 PM
This revision is now accepted and ready to land.Feb 15 2020, 6:02 PM
ongunkanat added a subscriber: ongunkanat.EditedFeb 20 2020, 1:23 AM


I am the reporter of this bug. I saw the e-mail but never had time to comment on the issue. It seems it has been approved quite fast. I am glad that it is at least possible to modify the style and GTK accepts those changes without hassle.

However I have a suggestion to make it even more clear for 3rd party developers. The suffix _breeze seems like only Breeze-GTK can follow those colors but if it works on Breeze-GTK probably other themes can also implement same color class names with the _breeze. So from a 3rd party GTK theme developer's point of view it looks like a Breeze specific feature although they probably can implement Plasma compatibility for their own theme too if they want to follow KDE's API.

So in my humble opinion using _plasma or _kde_plasma suffix would be a clearer and better indicator for this feature.

Thanks for the effort!

This revision was automatically updated to reflect the committed changes.