Differential D27421

[Cuttleffish] Use proper QSortFilterProxyModel
ClosedPublic
Actions

Authored by davidre on Feb 15 2020, 11:47 AM.

Details

Reviewers
apol
Group Reviewers
Plasma
Commits
R118:2bae103fa66e: [Cuttleffish] Use proper QSortFilterProxyModel
Summary

Don't reload everything when filter or category is changed. Fixes selected icon
changing when filtering and the first icon not being selectd when the current
icon is selected.

Test Plan

select and filter

Diff Detail

Repository
R118 Plasma SDK
Branch
searchproxy (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 23403
Build 23421: arc lint + arc unit
davidre created this revision.Feb 15 2020, 11:47 AM
Restricted Application added a project: Plasma. · View Herald TranscriptFeb 15 2020, 11:47 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
davidre requested review of this revision.Feb 15 2020, 11:47 AM
davidre updated this revision to Diff 75742.Feb 15 2020, 11:48 AM

Add new files

apol added a subscriber: apol.Mar 3 2020, 7:58 PM
apol added inline comments.
cuttlefish/src/iconmodel.h
100

m_category can be removed?

102

m_filter can be removed now, right?

davidre updated this revision to Diff 77171.Mar 7 2020, 3:42 PM

Remove members that are not needed anymore

apol accepted this revision.Mar 9 2020, 2:05 AM
This revision is now accepted and ready to land.Mar 9 2020, 2:05 AM
Closed by commit R118:2bae103fa66e: [Cuttleffish] Use proper QSortFilterProxyModel (authored by davidre). · Explain WhyMar 11 2020, 10:02 AM
This revision was automatically updated to reflect the committed changes.

Showing Only Differences

This revision modifies 10 more files that are hidden because they were not modified between selected diffs and they have no inline comments.

Revision Contents
Changeset List

PathPackages
Mcuttlefish/src/iconmodel.h (14 lines)

Diff 77171

View Options

cuttlefish/src/iconmodel.h

Loading...