Add small icons for KeePassXC
ClosedPublic

Authored by wsdfhjxc on Feb 14 2020, 6:12 PM.

Details

Summary

Diff Detail

Repository
R266 Breeze Icons
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
wsdfhjxc created this revision.Feb 14 2020, 6:12 PM
Restricted Application added a project: Frameworks. Β· View Herald TranscriptFeb 14 2020, 6:12 PM
Restricted Application added a subscriber: kde-frameworks-devel. Β· View Herald Transcript
wsdfhjxc requested review of this revision.Feb 14 2020, 6:12 PM
wsdfhjxc edited the summary of this revision. (Show Details)Feb 14 2020, 6:14 PM
cblack requested changes to this revision.Tue, Mar 17, 2:13 AM
cblack added a subscriber: cblack.

The key in both icons should be pixel aligned to prevent blurry edges at the size it's going to be rendered at.

This should also be in status/ instead of apps/ as it's a tray icon.

This revision now requires changes to proceed.Tue, Mar 17, 2:13 AM
ndavis requested changes to this revision.Tue, Mar 17, 2:16 AM
ndavis added a subscriber: ndavis.

Since this is a systray icon, you don't actually need to do the 16px version, but I guess there's no harm in having a 16px version.

As @cblack said, this needs some work on the pixel alignment. If you don't do the 16px version, it'll be significantly less work.

The orange X should be a lock emblem instead. See the firewall-applet-panic icon.

wsdfhjxc updated this revision to Diff 77809.Tue, Mar 17, 9:46 AM

Update small icons for KeePassXC

wsdfhjxc edited the summary of this revision. (Show Details)Tue, Mar 17, 9:48 AM
wsdfhjxc edited the summary of this revision. (Show Details)Tue, Mar 17, 11:31 AM

Is it any better now? @cblack @ndavis

ndavis accepted this revision.Tue, Mar 17, 5:35 PM

LGTM

cblack accepted this revision.Tue, Mar 17, 5:55 PM

LGTM now. Good icon πŸ‘Œ

This revision is now accepted and ready to land.Tue, Mar 17, 5:55 PM
This revision was automatically updated to reflect the committed changes.