Differential D27415

Use KConfigDialogManager to manage main window settings
ClosedPublic
Actions

Authored by davidre on Feb 14 2020, 5:11 PM.

Details

Reviewers
ngraham
ervin
Group Reviewers
Spectacle
Commits
R166:e8b4c291cc2d: Use KConfigDialogManager to manage main window settings
Summary

They are still instant apply. But are now automatically saved again. This makes
the settings consistent when opneing a new instance when another is still
running.

Diff Detail

Repository
R166 Spectacle
Branch
mainwindow
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 22503
Build 22521: arc lint + arc unit
davidre created this revision.Feb 14 2020, 5:11 PM
Restricted Application added a project: Spectacle. · View Herald TranscriptFeb 14 2020, 5:11 PM
davidre requested review of this revision.Feb 14 2020, 5:11 PM
ngraham accepted this revision.Feb 15 2020, 11:39 PM

@davidre, does this look good to you?

This revision is now accepted and ready to land.Feb 15 2020, 11:39 PM
davidre added a comment.Feb 16 2020, 8:05 AM

I guess? Note that I authored this diff :)

ngraham added a comment.Feb 16 2020, 5:40 PM

Oh wow, silly me. Shipit!

davidre edited the summary of this revision. (Show Details)Feb 21 2020, 7:36 AM
Closed by commit R166:e8b4c291cc2d: Use KConfigDialogManager to manage main window settings (authored by davidre). · Explain WhyFeb 21 2020, 7:37 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/Gui/KSWidget.h (3 lines)
Msrc/Gui/KSWidget.cpp (31 lines)

Diff 75720

View Options

src/Gui/KSWidget.h

Loading...
View Options

src/Gui/KSWidget.cpp

Loading...