Differential D27414

Fix area charts with Qt 5.14
ClosedPublic
Actions

Authored by vkrause on Feb 14 2020, 4:59 PM.

Details

Reviewers
apol
davidedmundson
Commits
R849:140c8ce688df: Fix area charts with Qt 5.14
Summary

BUG: 416061
BUG: 417597

Diff Detail

Repository
R849 User Feedback Collection Framework
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
vkrause requested review of this revision.Feb 14 2020, 4:59 PM
vkrause created this revision.
apol added a comment.Feb 15 2020, 8:08 PM

I have no idea how this works. Looking at the documentation my impression is "it does the same". But then, if it fixes 2 bugs...

vkrause added a comment.Feb 15 2020, 10:01 PM

The difference is that the QAreaSeries ctor uses one of its arguments as parent (which makes no sense here, given they are semantically children), the explicit setters don't do that.

apol accepted this revision.Feb 16 2020, 12:54 AM

Right, makes sense then.

This revision is now accepted and ready to land.Feb 16 2020, 12:54 AM
davidedmundson accepted this revision.Feb 16 2020, 7:10 AM
Closed by commit R849:140c8ce688df: Fix area charts with Qt 5.14 (authored by vkrause). · Explain WhyFeb 16 2020, 9:49 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 75761

View Options

src/console/analytics/categoryaggregator.cpp

Loading...
View Options

src/console/analytics/ratiosetaggregator.cpp

Loading...