[Window Switcher] Cleanup
ClosedPublic

Authored by broulik on Sep 11 2016, 7:38 PM.

Details

Summary

This cleans up and simplifies the tabbox code, mainly by replacing manual anchoring by QtQuick Layouts.
Spacing and fonts are also streamlined.

Test Plan

I was thinking about widening the tabbox to fit Plasma's sidebars (widget explorer / activity manager) but then the window thumbnails became so large I could only see three windows at a time.

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik updated this revision to Diff 6629.Sep 11 2016, 7:38 PM
broulik retitled this revision from to [Window Switcher] Cleanup.
broulik updated this object.
broulik edited the test plan for this revision. (Show Details)
broulik added reviewers: Plasma, Plasma: Design.
broulik set the repository for this revision to R119 Plasma Desktop.
Restricted Application added a project: Plasma. · View Herald TranscriptSep 11 2016, 7:38 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

Why is the font for the window titles so large? I don't really see much benefit from that...

It was to match the icon and task manager tooltips but I can also just use regular Plasma font size.

mart added a subscriber: mart.Sep 13 2016, 11:37 AM

+1 code looks good,
using headings as window titles looks good to me, but ok on whatever vdg decides

I've just asked the other VDG members for their take on the font size.
Since this is not a big issue either way, the patch is fine to go in anyway.
If the VDG decides we'd like the font to be smaller, it would be nice if it could be changed in another patch.

andreaska added a subscriber: andreaska.EditedSep 13 2016, 12:55 PM

LibreOffice change there background for the document preview from white to gray cause show screenshots from a white paper on a white background, ... the screenshots lose the focus. So is it possible to use the dark background from the dash as background for the window switcher. The screenshots would be more visible (I'm not sure how it would look in breeze-dark)

thanks for the patch kai

I'd rather not change the fundamental visuals of this thing now.

If we were to add a dark gray background to the window thumbnails (which I find a good idea, btw) we should do that consistently everywhere (eg. also in task manager tooltips).

As discussed with Thomas I'll push it now as is and once VDG makes up their mind on the fonts (preferably before Thursday noon...) we can still change it.

This revision was automatically updated to reflect the committed changes.