@mlaurent ^^

In D27408#613565, @ngraham wrote:

@mlaurent ^^

Just a question: How I can see it if nobody adds me as reviewer (if I remember I was the only one guys who works against qt5.15 from several months so why don't add me as reviewer ? )? (For sure I have some scripts for automate theses changes so I commit quickly it)

but this patch was wrong as QOverload<int, const QString&>::of(&QComboBox::currentIndexChanged), was created in qt5.15 not in "<= qt5.15" so in qt5.15.1 it will failed when we compile without deprecated methods.

In D27408#613598, @mlaurent wrote:

Just a question: How I can see it if nobody adds me as reviewer (if I remember I was the only one guys who works against qt5.15 from several months so why don't add me as reviewer ? )? (For sure I have some scripts for automate theses changes so I commit quickly it)

Do you want us to add you on every review? I'd say you can just subscribe to Plasma and Frameworks if you are planning to work on Plasma and Frameworks.

no each reviews but when you create a patch for qt5.15 as I was the only dev which worked on qt5.15 it was logical to add me.
I will not subscribe for each commit in plasma/framework, for sure after 20-30 commits I will not read them. I have ~ 200 mails by days, so for sure I will not be able to read them.

In D27408#613637, @mlaurent wrote:

no each reviews but when you create a patch for qt5.15 as I was the only dev which worked on qt5.15 it was logical to add me.
I will not subscribe for each commit in plasma/framework, for sure after 20-30 commits I will not read them. I have ~ 200 mails by days, so for sure I will not be able to read them.

We all get that many emails per day, or more.

Making sure that commits get reviewed is an important part of keeping up the quality. Even obvious-seeming bugfixes can regress things. If your workflow makes it impossible for you to seek review for your commits, or to review other people's commits, then maybe there's something wrong with your workflow.

So you review all patch from all repo ? :) awesome ! I am not able to do it! And I don't want to do it otherwise no possible to work on my projects.
But I am happy that you do it ! :)

So for sure I will not review all patchs from framework/plasma, but I am not against for reviewing qt5.15 patch.

Yes I at least look at all new patches for Plasma, Frameworks, and many KDE apps. If I'm capable of reviewing them, I do. If not, I try to add people to the reviewers list who I think can, if they're not already marked as reviewers.

We can add you as a reviewer for porting/Qt-related patches, sure.